Repository navigation
fix(web): relaunch Chrome when it never opens its debugging port - #385
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 30 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
biggest-littlest
left a comment
biggest-littlest
left a comment
There was a problem hiding this comment.
One added error pattern in the Lighthouse Chrome relaunch matcher, with a test case. 14 required checks and Web Contract green on fbd6ad0. CodeRabbit was out of free reviews; no outside review on this one.
ALARGECOMPANY
left a comment
ALARGECOMPANY
left a comment
There was a problem hiding this comment.
One added error pattern in the Lighthouse Chrome relaunch matcher, with a test case. 14 required checks and Web Contract green on fbd6ad0. CodeRabbit was out of free reviews; no outside review on this one.
3 participants
Web Contract has failed four times since 2026-10-06 with
waiting for dynamic debugging port in chrome-err.log, twice in a row today on #384. That's chrome-launcher's launch timeout: Chrome started and never wrote its DevTools port.The Lighthouse runner already relaunches Chrome up to
LIGHTHOUSE_CHROME_ATTEMPTStimes, but only for errorsisChromeConnectionErrorrecognises, and that message wasn't one of them. So the launch failure was thrown straight out and the job failed without a retry.This adds the message to the matcher, with a test case. Budget failures still don't match, so a real regression can't be retried into a pass.