Skip to content

Replace bare except clauses with specific exception handling #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaideepj2004 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace bare except clauses with specific exception handling #4986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions apps/analytics/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import csv
import logging
from datetime import timedelta

from accounts.permissions import HasVerifiedEmail
Expand Down Expand Up @@ -170,7 +171,11 @@ def get_challenge_phase_submission_count_by_team(
)
response_data = serializer.data
return Response(response_data, status=status.HTTP_200_OK)
except: # noqa: E722
except (TypeError, ValueError, AttributeError) as e:
logger = logging.getLogger(__name__)
logger.error(
"Error serializing challenge phase submission count: %s", str(e)
)
response_data = {"error": "Bad request. Please try again later!"}
return Response(response_data, status=status.HTTP_400_BAD_REQUEST)

Expand Down Expand Up @@ -267,7 +272,11 @@ def get_last_submission_datetime_analysis(
)
response_data = serializer.data
return Response(response_data, status=status.HTTP_200_OK)
except: # noqa: E722
except (TypeError, ValueError, AttributeError) as e:
logger = logging.getLogger(__name__)
logger.error(
"Error serializing last submission timestamp: %s", str(e)
)
response_data = {"error": "Bad request. Please try again later!"}
return Response(response_data, status=status.HTTP_400_BAD_REQUEST)

Expand Down