Replace bare except clauses with specific exception handling#4986
Open
jaideepj2004 wants to merge 1 commit into
Open
Replace bare except clauses with specific exception handling#4986jaideepj2004 wants to merge 1 commit into
jaideepj2004 wants to merge 1 commit into
Conversation
- Replace bare except clauses in apps/analytics/views.py with specific exception handling (TypeError, ValueError, AttributeError) - Add logging for better debuggability when serialization errors occur - Remove noqa: E722 suppression comments - Follows Python best practices (PEP 8) Fixes Cloud-CV#4890
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #4890 by replacing bare
exceptclauses with specific exception handling inapps/analytics/views.py.Changes Made
loggingimport at the top of the fileexcept:clauses withexcept (TypeError, ValueError, AttributeError) as e:# noqa: E722suppression commentsWhy These Changes?
Bare
exceptclauses are considered a bad practice in Python because they:KeyboardInterrupt,SystemExit)Specific Exceptions Caught
The exceptions chosen (
TypeError,ValueError,AttributeError) are appropriate for serialization errors:Testing Performed
✅ Syntax validation:
python -m py_compile apps/analytics/views.py- passed✅ Code quality:
flake8 apps/analytics/views.py- no errors✅ Exception handling: Verified all three exception types are correctly caught
✅ No remaining bare excepts: Confirmed no other bare except clauses remain in file
Benefits
Files Affected
apps/analytics/views.py(2 locations updated)Related Issue
Fixes #4890
Note: This is my third contribution to EvalAI. My previous PRs (#4977, #4978) were documentation improvements that were successfully merged. Looking forward to contributing more! 🚀