Skip to content

Get type journal-article from ORCID and keep old filtering for other sources #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbisits merged 4 commits into from
Jul 21, 2026
Merged

Get type journal-article from ORCID and keep old filtering for other sources #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f85b77
Try a fix
jbisits Jul 20, 2026
8ff6abb
try type instead of type.value
jbisits Jul 21, 2026
5b9198b
Update citations
jbisits Jul 21, 2026
e2f96c0
comment indicating only for non-orcid citations
jbisits Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified _cite/.cache/cache.db
View file
Open in desktop
Binary file not shown.
10 changes: 6 additions & 4 deletions _cite/cite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@
log("Generating citations")

# List of Journals to include as publishers on the website
# this is only for when the citation is **not** retrieved from
# an ORCID id.
journals = [
"Annual Review of Marine Science",
"Bulletin of the American Meteorological Society",
Expand Down Expand Up @@ -200,10 +202,10 @@
# orcid source: filter by work type
if work_type in ["journal-article", "preprint"]:
citations.append(citation)
# else:
# # other sources: filter by publisher list
# if get_safe(citation, "publisher", "") in journals:
# citations.append(citation)
else:
# other sources: filter by publisher list
if get_safe(citation, "publisher", "") in journals:
citations.append(citation)

log()

Expand Down
2 changes: 1 addition & 1 deletion _cite/plugins/orcid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def sort_id(_id):

# get work type from summaries
work_type = next(
(get_safe(s, "type.value", "") for s in summaries if get_safe(s, "type.value", "")),
(get_safe(s, "type", "") for s in summaries if get_safe(s, "type", "")),
""
)

Expand Down
Loading
Loading