Get type journal-article from ORCID and keep old filtering for other sources#54
Merged
Conversation
|
jbisits
force-pushed
the
jib/fix-citations
branch
from
July 21, 2026 00:07
cd9b36c to
8ff6abb
Compare
jbisits
changed the title
journal-articl from ORCID and keep old filtering for other sources
jbisits
changed the title
journal-articl from ORCID and keep old filtering for other sourcesjournal-article from ORCID and keep old filtering for other sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We get all our citations in
citations.yamlfrom ORCID ids. Previously I had a bit of a hack version to check if an article was published in a list ofjournalsto avoid publishing e.g. data hosted on figshare. This PR updatesocrcid.pyto retrive thetypeof a citation and only appends to the list if it is ajournal-article.