Tests and docs#607
Merged
Merged
Conversation
tapios
force-pushed
the
ts/tests-docs
branch
3 times, most recently
from
July 10, 2026 06:25
e953786 to
56a2a42
Compare
tapios
marked this pull request as ready for review
July 10, 2026 06:47
tapios
force-pushed
the
ts/tests-docs
branch
2 times, most recently
from
July 11, 2026 18:44
4e661d6 to
afccac4
Compare
tapios
force-pushed
the
ts/tests-docs
branch
3 times, most recently
from
July 11, 2026 21:05
c14c26b to
8c07424
Compare
…r-2 API contract, and advisory GPU/CPU benchmark ratchet
…formance comparisons
szy21
reviewed
Jul 12, 2026
szy21
reviewed
Jul 12, 2026
szy21
reviewed
Jul 12, 2026
szy21
reviewed
Jul 12, 2026
szy21
reviewed
Jul 12, 2026
Member
Author
|
Yes, it’s not deterministically reproducible on GPUs. To make it reproducible, we’d have to pass, e.g., a column index as seed (what I had a week ago or so). (Here it says it’s statistically reproducible, which is true but perhaps unhelpful.)
On Jul 11, 2026, at 20:18, Zhaoyi Shen ***@***.***> wrote:
@szy21 commented on this pull request.
________________________________
In docs/src/howto/gpu.md<#607 (comment)>:
+stochastically (McICA) using the global RNG. On the CPU,
+`update_fluxes!(solver, seed)` with `reset_rng_seed = true` makes results
+reproducible. On the GPU, the per-thread RNG state produces statistically
My claude says it's only reproducible on single-threaded CPU. Is that the case?
—
Reply to this email directly, view it on GitHub<#607?email_source=notifications&email_token=ADT3LJHJIWS4ZHQVJGBCBDT5EL7OFA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRXHEZTCNRSGI22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4679316225>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADT3LJEDJJZOT5ZV5XZWZA35EL7OFAVCNFSNUABFKJSXA33TNF2G64TZHMZDAOBTGIZTSNZQHNEXG43VMU5TIOBUGM2TCMZXGA22C5QC>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
szy21
approved these changes
Jul 12, 2026
Co-authored-by: Zhaoyi Shen <11598433+szy21@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last major step of RRTMGP refactor:
Closes #515, #585