[CHIA-4279] parse ProofOfSpace - #1474
Merged
Merged
Conversation
…original Option<> parsing
AmineKhaldi
approved these changes
Jun 30, 2026
Coverage Report for CI Build 28447616578Warning No base build found for commit Coverage: 80.971%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make parsing of ProofOfSpace more strict and less maleable, like the original Option<> parsing
Note
High Risk
Changes consensus-relevant ProofOfSpace deserialization; stricter parsing could reject previously accepted (malleable) encodings on the wire.
Overview
Tightens
ProofOfSpacewire parsing so the packed pool_contract prefix byte is interpreted like a normalOption<>prefix (only bits 0–1 are meaningful), reducing malleability on the network.Parse change: version is derived with
prefix >> 1instead of treating only bit 1 as a boolean. Non-canonical prefixes that set higher bits now surface as unknown versions and fail withInvalidPoS, rather than being accepted as v0/v1 with altered optional semantics.Tests: Adds helpers and expands coverage for serialize/parse round-trips (v0 lenient pool/contract combinations, v1
sizecollapsing to 0), explicit rejections (v1 must have exactly one of pool pk vs contract, unknown version on serialize), and regression that bits 2–7 on the prefix byte are rejected for both versions.Reviewed by Cursor Bugbot for commit 3a65f0e. Bugbot is set up for automated code reviews on this repo. Configure here.