checkpoint ProofOfSpace patch - #1476
Merged
Merged
Conversation
…original Option<> parsing
Coverage Report for CI Build 28453872876Coverage increased (+0.02%) to 81.527%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
AmineKhaldi
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make parsing of ProofOfSpace more strict and less maleable, like the original Option<> parsing
Original PR against
release/0.45.1: #1474Note
Medium Risk
Changes consensus-relevant proof serialization parsing; behavior shifts for malformed prefix bytes while intended valid encodings should stay compatible.
Overview
Tightens
ProofOfSpacewire parsing by derivingversionfrom the packed optional prefix asprefix >> 1instead of treating only bit 1 as a boolean, so encodings with garbage high bits map to invalid versions and fail like stricterOption<>-style prefixes.Expands unit coverage with helpers for building proofs and locating the prefix byte, plus
roundtrip,parse_rejects, andhigh_prefix_bits_rejectedcases for legacy v0 lenient pool/contract combinations, v1 XOR pool-vs-contract rules, unknown versions, and stable re-serialization.Reviewed by Cursor Bugbot for commit 2d6741c. Bugbot is set up for automated code reviews on this repo. Configure here.