ci: fix pre-commit EOF + TOC push permission#2
Merged
Conversation
- end-of-file-fixer: trim the double trailing newline on two openspec spec files so pre-commit passes (verified: pre-commit run --all-files is green). - toc.yaml: add permissions.contents=write so the TOC generator's push to main stops 403-ing as github-actions[bot]. Does not touch the pytest/Docker core-checkout harness (PHCC migration) — that is a separate, design-level change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unbreaks two of the four failing CI workflows. Verified locally:
pre-commit run --all-filesis fully green.Fixes
end-of-file-fixer):openspec/specs/options-flow/spec.mdandruntime-range-controls/spec.mdended with a double trailing newline (a blank line at EOF); trimmed to a single newline.permissions: contents: writetotoc.yaml. It was failing with403 — Permission to CaseyRo/adaptive-lighting.git denied to github-actions[bot]when pushing the generated TOC tomain.Not included (separate change)
pytestandDockerremain red — they share a deeper root: the tests were rewritten PHCC-style (pytest-homeassistant-custom-component, green locally at 164 passed) but CI still runs the upstream HA-core-checkout harness that doesn't install PHCC, and the Docker build dies oncore/requirements_test_all.txt(HAdevmoved it). That's a design-level harness decision, tracked separately.Note: if
permissions: contents: writestill 403s, flip Settings → Actions → Workflow permissions to 'Read and write'.