ci: migrate pytest + Docker to PHCC (retire HA core-checkout harness)#3
Merged
Conversation
Design-first per repo convention. Migrates pytest + Docker CI off the dead HA core-checkout harness to the PHCC-based local test suite that already passes locally (164). Implementation (tasks + code) held pending review of the design's open questions.
Implements openspec change migrate-ci-to-phcc.
- pytest.yaml: run the local PHCC suite (latest + dev matrix; dev is
continue-on-error). Fixes the trigger (was push:[master] -> never ran on
main; now main). Drops coverage (was computed but never uploaded). Recipe
verified in a clean env locally: 164 passed, Python 3.13, latest PHCC.
- Delete dead core-checkout scaffolding: install_dependencies action,
setup-dependencies, setup-symlinks, update-test-matrix.{py,yaml},
test_dependencies.py, Dockerfile, docker-build.yml.
- setup-devcontainer: PHCC flow (uv sync --group test).
- tests/README.md: rewritten for 'uv run pytest'.
- CLAUDE.md: drop the 'Refresh test matrix' row.
- hacs.json 2024.12.0 -> 2026.1.0; README min-version line corrected (it
wrongly claimed '2025.1.0 pinned in manifest.json' - manifest pins none).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
pytestandDockerCI failures. Implements openspec changemigrate-ci-to-phcc(proposal + design + tasks inopenspec/changes/).Root cause
The tests were rewritten PHCC-style (
pytest-homeassistant-custom-component, green locally at 164 passed) but CI still ran the upstream HA-core-checkout harness, which never installs PHCC →ModuleNotFoundErroron every entry. Docker built the same core-checkout image and died oncore/requirements_test_all.txt(HAdevmoved it).What changed
pytest.yamlrewritten to run the local PHCC suite. Two-entry matrix: stable (latest PHCC) and dev (--pre,continue-on-error). Recipe verified in a clean env locally (164 passed, Python 3.13, latest PHCC).push: branches: [master]— the default branch ismain, so it never ran on main.install_dependenciesaction,setup-dependencies,setup-symlinks,update-test-matrix.{py,yaml},test_dependencies.py,Dockerfile,docker-build.yml.setup-devcontainer→ PHCC flow (uv sync --group test);tests/README.mdrewritten;CLAUDE.mddrops the 'Refresh test matrix' row.hacs.json2024.12.0→2026.1.0; README min-version line fixed (it wrongly claimed2025.1.0'pinned in manifest.json' — the manifest pins none).Not changed
No
custom_components/code, no test files. Coverage (--cov) dropped (was computed but never uploaded).Depends on / complements #2 (pre-commit + TOC quick wins).