-
Notifications
You must be signed in to change notification settings - Fork 2
update packages #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update packages #198
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | ||
| <CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup Label="Application"> | ||
| <PackageVersion Include="Ardalis.SmartEnum" Version="8.2.0" /> | ||
| <PackageVersion Include="FluentValidation" Version="12.1.1" /> | ||
| <PackageVersion Include="Microsoft.ApplicationInsights" Version="2.23.0" /> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The ITHC document lists 3.1.2 as the current version. If there are breaking changes in the 3.x release line that make upgrading non-trivial, could you add a note here or on the ticket explaining why we're remaining on 2.x? Otherwise, it appears this may have been overlooked. |
||
| <PackageVersion Include="Microsoft.ApplicationInsights.WorkerService" Version="2.23.0" /> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The ITHC identifies 3.1.2 as the latest version. If the 3.x upgrade is blocked by the same breaking changes as the base AppInsights SDK, please add a note linking the two items so there's a clear record of why we're remaining on 2.x. |
||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker" Version="2.52.0" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.ApplicationInsights" Version="2.51.0" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCore" Version="2.1.1" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.Extensions.OpenApi" Version="1.6.0" /> | ||
| <PackageVersion Include="Microsoft.Azure.Functions.Worker.Sdk" Version="2.0.7" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Azure" Version="1.14.0" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Http.Resilience" Version="10.8.0" /> | ||
| <PackageVersion Include="Microsoft.IdentityModel.Protocols" Version="8.22.0" /> | ||
| <PackageVersion Include="Microsoft.IdentityModel.Protocols.OpenIdConnect" Version="8.22.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Label="Test"> | ||
| <PackageVersion Include="AutoFixture" Version="4.18.1" /> | ||
| <PackageVersion Include="AutoFixture.AutoMoq" Version="4.18.1" /> | ||
| <PackageVersion Include="AutoFixture.Xunit2" Version="4.18.1" /> | ||
| <PackageVersion Include="coverlet.collector" Version="10.0.1" /> | ||
| <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.8.1" /> | ||
| <PackageVersion Include="Moq" Version="4.20.72" /> | ||
| <PackageVersion Include="xunit" Version="2.9.3" /> | ||
| <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" /> | ||
| </ItemGroup> | ||
| </Project> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ITHC flagged outdated transitive deps too (Grpc 2.65→2.80, Newtonsoft 13.0.1→13.0.4, YamlDotNet 12→18, Protobuf 3.28→3.35). With this set to
falsenone of those get pinned. Was there a reason not to enable it? If restore breaks with it on, fair enough, but worth a comment here explaining the decision so anyone can see it was a conscious choice rather than an oversight.