update packages - #198
Conversation
|
| <Project> | ||
| <PropertyGroup> | ||
| <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally> | ||
| <CentralPackageTransitivePinningEnabled>false</CentralPackageTransitivePinningEnabled> |
There was a problem hiding this comment.
The ITHC flagged outdated transitive deps too (Grpc 2.65→2.80, Newtonsoft 13.0.1→13.0.4, YamlDotNet 12→18, Protobuf 3.28→3.35). With this set to false none of those get pinned. Was there a reason not to enable it? If restore breaks with it on, fair enough, but worth a comment here explaining the decision so anyone can see it was a conscious choice rather than an oversight.
| <ItemGroup Label="Application"> | ||
| <PackageVersion Include="Ardalis.SmartEnum" Version="8.2.0" /> | ||
| <PackageVersion Include="FluentValidation" Version="12.1.1" /> | ||
| <PackageVersion Include="Microsoft.ApplicationInsights" Version="2.23.0" /> |
There was a problem hiding this comment.
The ITHC document lists 3.1.2 as the current version. If there are breaking changes in the 3.x release line that make upgrading non-trivial, could you add a note here or on the ticket explaining why we're remaining on 2.x? Otherwise, it appears this may have been overlooked.
| <PackageVersion Include="Ardalis.SmartEnum" Version="8.2.0" /> | ||
| <PackageVersion Include="FluentValidation" Version="12.1.1" /> | ||
| <PackageVersion Include="Microsoft.ApplicationInsights" Version="2.23.0" /> | ||
| <PackageVersion Include="Microsoft.ApplicationInsights.WorkerService" Version="2.23.0" /> |
There was a problem hiding this comment.
The ITHC identifies 3.1.2 as the latest version. If the 3.x upgrade is blocked by the same breaking changes as the base AppInsights SDK, please add a note linking the two items so there's a clear record of why we're remaining on 2.x.
2 participants
No description provided.