Skip to content

Add guards to assignment of RTTOV trace gas profiles when ppmv units are used #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RobertPincus merged 2 commits into from
May 1, 2026
Merged

Add guards to assignment of RTTOV trace gas profiles when ppmv units are used #156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e6ce30
Merge branch 'master' of https://github.com/CFMIP/COSPv2.0
jshaw35 Apr 30, 2026
e1db0ed
Add guards to trace gas assignments in rttov profile structure
jshaw35 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions src/simulator/rttov/cosp_rttov_v13.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,17 +754,6 @@ subroutine cosp_rttov_construct_profiles(rttovIN, &
else
inst_profiles(j)%skin%surftype = surftype_seaice
end if

! land-sea mask (lsmask) indicates proportion of land in grid (not in CESM implementation! just a binary mask there)
! if (rttovIN%lsmask(i) < 0.5) then
! inst_profiles(j)%skin%surftype = surftype_sea
! else
! inst_profiles(j)%skin%surftype = surftype_land
! endif
! sea-ice fraction
! if (rttovIN%icefrac(i) >= 0.5) then
! inst_profiles(j)%skin%surftype = surftype_seaice
! endif

! dar: hard-coded to 1 (=ocean water) in rttov 9 int
inst_profiles(j)%skin%watertype = 1
Expand All @@ -781,12 +770,12 @@ subroutine cosp_rttov_construct_profiles(rttovIN, &
! Convert to ppmv over dry air
inst_profiles(j)%s2m%q = (inst_profiles(j)%s2m%q / (1.0 - inst_profiles(j)%s2m%q)) * mdry / mH2O * 1.e6
inst_profiles(j)%q(:) = (inst_profiles(j)%q(:) / (1.0 - inst_profiles(j)%q(:))) * mdry / mH2O * 1.e6
inst_profiles(j)%o3(:) = inst_profiles(j)%o3(:) * mdry / mO3 * 1.e6
inst_profiles(j)%co2(:) = inst_profiles(j)%co2(:) * mdry / mCO2 * 1.e6
inst_profiles(j)%ch4(:) = inst_profiles(j)%ch4(:) * mdry / mCH4 * 1.e6
inst_profiles(j)%n2o(:) = inst_profiles(j)%n2o(:) * mdry / mN2O * 1.e6
inst_profiles(j)%co(:) = inst_profiles(j)%co(:) * mdry / mCO * 1.e6
inst_profiles(j)%so2(:) = inst_profiles(j)%so2(:) * mdry / mSO2 * 1.e6
if (Ldo_o3) inst_profiles(j)%o3(:) = inst_profiles(j)%o3(:) * mdry / mO3 * 1.e6
if (Ldo_co2) inst_profiles(j)%co2(:) = inst_profiles(j)%co2(:) * mdry / mCO2 * 1.e6
if (Ldo_ch4) inst_profiles(j)%ch4(:) = inst_profiles(j)%ch4(:) * mdry / mCH4 * 1.e6
if (Ldo_n2o) inst_profiles(j)%n2o(:) = inst_profiles(j)%n2o(:) * mdry / mN2O * 1.e6
if (Ldo_co) inst_profiles(j)%co(:) = inst_profiles(j)%co(:) * mdry / mCO * 1.e6
if (Ldo_so2) inst_profiles(j)%so2(:) = inst_profiles(j)%so2(:) * mdry / mSO2 * 1.e6
inst_profiles(j)%gas_units = 0
else
inst_profiles(j)%gas_units = inst_gas_units
Expand Down
Loading