Add guards to assignment of RTTOV trace gas profiles when ppmv units are used#156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/simulator/rttov/cosp_rttov_v13.F90 assigns trace gas mixing ratios to the RTTOV atmospheric profile object. Because not all trace gases are used for all simulations, logicals are used to guard against assigning garbage data to the profile object. These guards were missing when trace gas units of ppmv were used, which results in a runtime error in CESM when debug settings are turned on (thank you @cacraigucar for catching this).
This PR adds those guards and removes a block of commented code. No answers are changed and all tests pass.
Also, please create a new tag when this PR is merged so that it can be immediately brought into CESM3 (merge hopefully coming very soon!).