Skip to content

fix(release): make worthiness gate pipefail-safe #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
levi770 wants to merge 1 commit into from
Closed

fix(release): make worthiness gate pipefail-safe #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/release-plz.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,14 @@ jobs:
else
range="HEAD"
fi
if git log --format=%s "$range" | grep -qE '^(feat|fix|perf|refactor|docs|build|ci|test|revert)(\([^)]+\))?!?:' \
|| git log --format=%B "$range" | grep -q 'BREAKING CHANGE:'; then
release_subject_pattern='^(feat|fix|perf|refactor|docs|build|ci|test|revert)(\([^)]+\))?!?:'
if ! printf '%s\n' 'feat(runtime)!: valid breaking subject' | grep -E "$release_subject_pattern" >/dev/null \
|| printf '%s\n' 'feat!(runtime): malformed breaking subject' | grep -E "$release_subject_pattern" >/dev/null; then
echo "Release subject pattern must accept type(scope)!: and reject type!(scope):." >&2
exit 1
fi
if git log --format=%s "$range" | grep -E "$release_subject_pattern" >/dev/null \
|| git log --format=%B "$range" | grep 'BREAKING CHANGE:' >/dev/null; then
echo "Release-worthy commits found since ${last_tag:-repository start}."
else
echo "No release-worthy commits since ${last_tag:-repository start}; skipping release PR."
Expand Down