fix(release): make worthiness gate pipefail-safe - #260
Closed
levi770 wants to merge 1 commit into
Closed
Conversation
levi770
force-pushed
the
fix/release-worthiness-gate
branch
from
August 16, 2026 20:45
921a0cb to
8bef408
Compare
levi770
force-pushed
the
fix/release-worthiness-gate
branch
from
August 16, 2026 21:07
8bef408 to
cef6aeb
Compare
This was referenced Aug 16, 2026
Contributor
Author
|
The refreshed release-changelog child is now #265, based directly on this PR's current head |
Contributor
Author
|
Closing this PR because it was opened outside the user-authorized seven-PR scope (#245 and #253-#258). The branch is intentionally retained. If any change here is genuinely required to resolve a review finding, it will be independently verified and folded directly into the relevant original PR rather than published as another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set -o pipefailtype(scope)!:and rejects malformedtype!(scope):CHANGELOG.mduntouched so release-plz remains the changelog ownerRoot cause
The review on #197 reproduced
git log | grep -qreturning pipeline status 141 aftergrepexits on the first match andgit logreceives SIGPIPE. The workflow interpreted that matched history as a no-match and stopped refreshing the rolling release PR.Review reference: #197 (review)
Verification
Before the change, on
xlog-cli-v0.11.0..HEAD:BREAKING CHANGE:scan: status 141After the change:
BREAKING CHANGE:scan: status 0feat(runtime)!:fixture: status 0feat!(runtime):fixture: status 1git diff --check: cleanRelated to #197; this PR does not close or modify it.