Skip to content

fix: catch all requests exceptions in get_index to prevent unhandled NameResolutionError (closes #33691) #33775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
botbikamordehai2-sketch wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix: catch all requests exceptions in get_index to prevent unhandled NameResolutionError (closes #33691) #33775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli-core/azure/cli/core/extension/_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def get_index(index_url=None, cli_ctx=None):
return response.json()
msg = ERR_TMPL_NON_200.format(response.status_code, index_url)
raise CLIError(msg)
except (requests.exceptions.ConnectionError, requests.exceptions.HTTPError, ValueError) as err:
except (requests.exceptions.RequestException, ValueError) as err:
if try_number == TRIES - 1:
# ValueError indicates that shortlink url is not redirecting properly to intended index url
msg = ERR_TMPL_BAD_JSON.format(str(err)) if isinstance(err, ValueError) else \
Expand Down