fix: catch all requests exceptions in get_index to prevent unhandled NameResolutionError (closes #33691)#33775
Open
botbikamordehai2-sketch wants to merge 1 commit into
Conversation
…NameResolutionError (closes Azure#33691)
|
Hi @botbikamordehai2-sketch, |
|
Hi @botbikamordehai2-sketch, |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Collaborator
|
az find |
Member
|
@botbikamordehai2-sketch thanks for your contribuation! however, it's covered by #33491 with a new backend service (will release in the next comming azure-cli version). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
az findcommand crashes with an unhandledNameResolutionErrorwhen DNS resolution fails for the extension index endpoint (e.g.,app.aladdin.microsoft.comreturns NXDOMAIN). The exception is not caught by the existing except clause, causing a Python traceback instead of a user-friendly error.Fix
Replace
(requests.exceptions.ConnectionError, requests.exceptions.HTTPError, ValueError)with(requests.exceptions.RequestException, ValueError)in theget_index()function.RequestExceptionis the base class for all exceptions raised by therequestslibrary, including DNS resolution failures, connection errors, timeouts, and HTTP errors. This ensures any network-related error is caught and converted to aCLIErrorwith a clear message.Closes #33691