Repository navigation
Expand catalog, harden cart/search, prepare data layer (#34–#37) - #48
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Ava-91
left a comment
There was a problem hiding this comment.
I reviewed the CI failure. I don’t think this is ready to merge yet because the E2E suite is failing in all three browsers.
The main issues I found:
-
v1-flow.spec.tsstill expects6 plants, while this PR expands the catalog to 18. The E2E expectation needs to be updated to match the new catalog behavior. -
/shop/does-not-existis returning HTTP 200 instead of the expected 404. This looks like an actual routing/not-found behavior that needs to be fixed or intentionally updated. -
There are also two Unsplash image URLs returning 404s during the test run:
photo-1593691509547-9c4a5e1c0c1fphoto-1614594975526-a5d0d8d9b0b0
The Edge Runtime and scroll-behavior: smooth messages look like warnings/notices rather than the reason CI failed.
I’d fix the E2E failures and the broken image URLs, rerun CI, and then I’m happy to re-review.
Summary
Implements the open V1 polish issues for catalog, search/filter/sort, cart persistence, and a stable data layer for a future API.
Changes
ApiProduct+mapApiProduct+docs/DATA_LAYER.mdfor V2 API swapTest plan
/shopshows 18 plantsnpm run typecheckandnpm run buildpassCloses #34
Closes #35
Closes #36
Closes #37