Skip to content

Expand catalog, harden cart/search, prepare data layer (#34–#37) - #48

Merged
hoshiko9011 merged 1 commit into
mainfrom
feature/issues-34-37-catalog-cart-search-data
Sep 25, 2026
Merged

hoshiko9011 merged 1 commit into
mainfrom
feature/issues-34-37-catalog-cart-search-data

Conversation

@hoshiko9011

Copy link
Copy Markdown
Collaborator

Summary

Implements the open V1 polish issues for catalog, search/filter/sort, cart persistence, and a stable data layer for a future API.

Changes

Test plan

  • /shop shows 18 plants
  • Search “fern”, “pet”, “succulent”
  • Combine filters + sort; Clear filters works
  • Add to cart → refresh → quantities persist and respect stock
  • Sold out / Max in cart states on product controls
  • npm run typecheck and npm run build pass

Closes #34
Closes #35
Closes #36
Closes #37

@vercel

vercel Bot commented Sep 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
verdea Ready Ready Preview Sep 25, 2026 4:22pm UTC

@Ava-91
Ava-91 self-requested a review September 25, 2026 16:23

@Ava-91 Ava-91 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the CI failure. I don’t think this is ready to merge yet because the E2E suite is failing in all three browsers.

The main issues I found:

  • v1-flow.spec.ts still expects 6 plants, while this PR expands the catalog to 18. The E2E expectation needs to be updated to match the new catalog behavior.

  • /shop/does-not-exist is returning HTTP 200 instead of the expected 404. This looks like an actual routing/not-found behavior that needs to be fixed or intentionally updated.

  • There are also two Unsplash image URLs returning 404s during the test run:

    • photo-1593691509547-9c4a5e1c0c1f
    • photo-1614594975526-a5d0d8d9b0b0

The Edge Runtime and scroll-behavior: smooth messages look like warnings/notices rather than the reason CI failed.

I’d fix the E2E failures and the broken image URLs, rerun CI, and then I’m happy to re-review.

@hoshiko9011
hoshiko9011 merged commit d324b79 into main Sep 25, 2026
2 of 3 checks passed
@Ava-91
Ava-91 deleted the feature/issues-34-37-catalog-cart-search-data branch September 25, 2026 16:27
@Ava-91
Ava-91 restored the feature/issues-34-37-catalog-cart-search-data branch September 25, 2026 16:28

This branch was successfully deployed

1 active deployment
Preview — bd6a3762 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants