Repository navigation
fix: CI E2E plant count, product 404, broken image URLs - #49
hoshiko9011 wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Ava-91
left a comment
There was a problem hiding this comment.
CI is still failing on the E2E suite.
The original plant-count and invalid-product issues appear to be addressed, but all three main shopping flow works variants (Chromium, Firefox, and mobile) now fail at the same step:
getByRole("navigation", { name: "Main navigation" }).getByRole("link", { name: "Shop", exact: true }).click()
The test times out waiting for the Shop link, so it never reaches the /shop or 18 plants assertions.
Please investigate the main navigation/rendering or the E2E selector, fix the failure, and rerun the full CI suite. I’ll hold approval until CI is green.
|
CI is still failing, but the previous navigation issue is fixed. The latest run now gets past the Shop navigation and fails on two strict-mode locator issues:
All three browser projects hit the same issues. Please fix these selectors and rerun the full CI suite. I’ll hold approval until CI is green. |
Addresses review feedback after #48:
/shop/does-not-existnow returns 404 viadynamicParams = falseCloses follow-up to #48 review.