Skip to content

fix: CI E2E plant count, product 404, broken image URLs - #49

Open
hoshiko9011 wants to merge 3 commits into
mainfrom
fix/ci-e2e-images-404
Open

hoshiko9011 wants to merge 3 commits into
mainfrom
fix/ci-e2e-images-404

Conversation

@hoshiko9011

Copy link
Copy Markdown
Collaborator

Addresses review feedback after #48:

  • E2E expected "6 plants"; catalog is now 18
  • /shop/does-not-exist now returns 404 via dynamicParams = false
  • Replaced two Unsplash image IDs that returned 404

Closes follow-up to #48 review.

@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
verdea Ready Ready Preview Sep 25, 2026 5:21pm UTC

@Ava-91
Ava-91 self-requested a review September 25, 2026 16:37
@Ava-91 Ava-91 self-assigned this Sep 25, 2026

@Ava-91 Ava-91 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still failing on the E2E suite.

The original plant-count and invalid-product issues appear to be addressed, but all three main shopping flow works variants (Chromium, Firefox, and mobile) now fail at the same step:

getByRole("navigation", { name: "Main navigation" }).getByRole("link", { name: "Shop", exact: true }).click()

The test times out waiting for the Shop link, so it never reaches the /shop or 18 plants assertions.

Please investigate the main navigation/rendering or the E2E selector, fix the failure, and rerun the full CI suite. I’ll hold approval until CI is green.

@Ava-91

Ava-91 commented Sep 25, 2026

Copy link
Copy Markdown
Owner

CI is still failing, but the previous navigation issue is fixed.

The latest run now gets past the Shop navigation and fails on two strict-mode locator issues:

  1. getByLabel("Price") resolves to 19 elements because the product price elements also expose labels beginning with Price. Please make the selector exact, e.g. getByLabel("Price", { exact: true }).

  2. The invalid-product assertion getByText(/does not exist|404/i) resolves to both the 404 eyebrow and the “This leafy corner does not exist.” heading. Please target the specific heading/text instead.

All three browser projects hit the same issues. Please fix these selectors and rerun the full CI suite. I’ll hold approval until CI is green.

This branch was successfully deployed

1 active deployment
Preview — 361cf6fd Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants