Tests(#66): unit test evaluation and fixes - #71
Merged
Conversation
…ts of real numbers in `dietcheck`
pull `dev` into `tests/i66`
…is-Ecosystem-Model/atlantistools into tests/i66-unit-test-fixes
… prevent warnings
…ting test_that test
…n to prevent warnings
…mple data for tests and examples
…eds a rewrite. out of scope her. Commented out faling tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your commits explain the
who,what,whereandwhenof these changes. Your code shows thehow. You do not need to reiterate this. This PR should complete the big picture by telling thewhy.Justification
devtools:check()was failing due to failing unit tests. They either needed to be fixed or skipped. Some test are obsolete or need to be rewritten. That is out of scope here. Some test were fixed, other just omitted.fixes #66
Types of changes
What types of changes does your code introduce? Put an
xin the boxes that apply. This will inform version updatesFurther comments
These unit tests should rewritten. Using recent output from the SETAS model
Unit tests pointed to issue with unresolved standard evaluation. A bug fix
Reviewer instructions:
run
devtools::test()to run unit tests. Make sure none failFormatting
This repo contains an
air.tomlfile that automatically formats code to a set of standards.It is preferred that contributors and reviewers install the air formatting tool.