mavutil: add type annotations to mavfile subclasses (mavserial, mavud… - #1239
Open
khancyr wants to merge 1 commit into
Open
mavutil: add type annotations to mavfile subclasses (mavserial, mavud…#1239khancyr wants to merge 1 commit into
khancyr wants to merge 1 commit into
Conversation
…p, ...) Types FakeSerial and all mavfile subclasses: mavserial, mavudp, mavmcast, mavtcp, mavtcpin, mavlogfile, mavmmaplog, mavchildexec, mavwebsocket, and mavwebsocket_client. Widens mavfile.recv()'s return type to bytes | str to honestly reflect what these overrides actually return (several fall back to "" on error paths). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
peterbarker
reviewed
Jul 31, 2026
| pass | ||
|
|
||
| def recv_msg(self): | ||
| def recv_msg(self) -> Any: |
Contributor
There was a problem hiding this comment.
Why Any?
SHouldn't this be message-or-None?
Similarly elsewhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…p, ...)
Types FakeSerial and all mavfile subclasses: mavserial, mavudp, mavmcast, mavtcp, mavtcpin, mavlogfile, mavmmaplog, mavchildexec, mavwebsocket, and mavwebsocket_client. Widens mavfile.recv()'s return type to bytes | str to honestly reflect what these overrides actually return (several fall back to "" on error paths).
This Only set annotation and don't touch anything else ! No code modification