experimental LIN taxonomy integration#73
Draft
bluegenes wants to merge 1 commit into
Draft
Conversation
keithchev
marked this pull request as draft
June 23, 2025 15:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[note: this is an experimental/draft PR and should not be merged as-is]
ref #72
In sourmash taxonomy, we're adding utils to use the
LINtaxonomic framework, which allows for greater flexibility and specificity compared with standard taxonomic ranks. For example, if only certain strains of a microbe are pathogenic, the LIN framework may be useful for identifying/grouping pathogenic vs non-pathogenic strains. Is this something you're interested in allowing for viz?We had a question about whether
sourmashconsumrwould work withLINlineages for e.g.sankeyplots, so I decided to experiment a little to see how easy/hard it would be to allow LIN functionality.This PR has lins semi working for:
tax_glom_taxonomy_annotateplot_taxonomy_annotate_sankeyplot using sourmash test data from the lins PR (

tests/test-data/tax/test1.gather.csvannotated withtests/test-data/tax/test.LIN-taxonomy.csv):Challenges and thoughts
0;0;1prefix vs the0;1;1prefix). These groups are given names, which would be a bit nicer for plotting. However, using LINgroup names would currently require reading in a separate lingroup file or using thelingroupreport fromtax metagenome0;1;1at a rank/position rather than the individual value).I am happy to work on this further or drop it, if this isn't something you want to allow!