Skip to content

Stop logging decrypted APDU payloads and MAC keys #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bahadirtmzr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Stop logging decrypted APDU payloads and MAC keys #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/NFCPassportReader/TagReader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,9 +279,9 @@ public class TagReader {

if let sm = self.secureMessaging {
rep = try sm.unprotect(rapdu:rep)
Logger.tagReader.debug("\(String(format:"TagReader [SM - unprotected] \(binToHexRep(rep.data, asArray:true)), sw1:0x%02x sw2:0x%02x", rep.sw1, rep.sw2))" )
Logger.tagReader.debug("TagReader [SM - unprotected] \(rep.data.count)b, sw1:0x\(String(format:"%02x", rep.sw1)) sw2:0x\(String(format:"%02x", rep.sw2))" )
} else {
Logger.tagReader.debug("\(String(format:"TagReader [unprotected] \(binToHexRep(rep.data, asArray:true)), sw1:0x%02x sw2:0x%02x", rep.sw1, rep.sw2))" )
Logger.tagReader.debug("TagReader [unprotected] \(rep.data.count)b, sw1:0x\(String(format:"%02x", rep.sw1)) sw2:0x\(String(format:"%02x", rep.sw2))" )

}

Expand Down
7 changes: 0 additions & 7 deletions Sources/NFCPassportReader/Utils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,19 +189,12 @@ public func desMAC(key : [UInt8], msg : [UInt8]) -> [UInt8]{
Logger.passportReader.debug("Calc mac" )
for i in 0 ..< size {
let tmp = [UInt8](msg[i*8 ..< i*8+8])
Logger.passportReader.debug("x\(i): \(binToHexRep(tmp))" )
y = DESEncrypt(key: [UInt8](key[0..<8]), message: tmp, iv: y)
Logger.passportReader.debug("y\(i): \(binToHexRep(y))" )
}

Logger.passportReader.debug("y: \(binToHexRep(y))" )
Logger.passportReader.debug("bkey: \(binToHexRep([UInt8](key[8..<16])))" )
Logger.passportReader.debug("akey: \(binToHexRep([UInt8](key[0..<8])))" )
let iv : [UInt8] = [0,0,0,0,0,0,0,0]
let b = DESDecrypt(key: [UInt8](key[8..<16]), message: y, iv: iv, options:UInt32(kCCOptionECBMode))
Logger.passportReader.debug( "b: \(binToHexRep(b))" )
let a = DESEncrypt(key: [UInt8](key[0..<8]), message: b, iv: iv, options:UInt32(kCCOptionECBMode))
Logger.passportReader.debug( "a: \(binToHexRep(a))" )

return a
}
Expand Down