Stop logging decrypted APDU payloads and MAC keys - #276
Open
bahadirtmzr wants to merge 1 commit into
Open
Conversation
TagReader dumped unprotected response bodies (DG1/DG2) at debug. desMAC logged the Retail-MAC key halves. Keep sizes and SW only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TagReader.send()logged the full unprotected response body after SM, including DG1 MRZ and DG2 image bytes.desMAC()logged Retail-MAC key halves.Debug logs now keep response size and status words only.