ci(android): run push quality gates on pull requests - #1554
Draft
Jeremy1844 wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit root
ADV-2026-0051/RC-005155405f66a8c555047dc0035747acdcaa371d59faddd5a410a86d709eb90d002dbbc3bbc3411add41Why
Pull requests currently run a macOS release bundle but omit the two quality commands required after push:
./gradlew checkand./gradlew testDebugUnitTest -Proborazzi.test.verify=true. A PR can therefore appear green and fail immediately after merge on compilation, lint, formatting, unit, or configured screenshot checks.Minimal fix
Add a bounded, secret-free Ubuntu quality job with
contents: read, non-persisting checkout, the repository's JDK 21/Gradle setup, a dependency-free fail-closed policy, and the exact two push-quality commands. The existing macOS release-bundle job is preserved byte-for-byte.No application code, content, schema, cache, persistence, signing, store, release artifact, or deployment behavior changes are included.
Regression evidence
check, 2,681 tasks.app:bundleRelease, 1,200 tasks.The published commit uses the account's GitHub noreply identity while preserving the tested tree, parent, message, dates, and stable patch ID.
Overlap and gates
Open Android PRs #1548-#1553 have zero changed-file/root overlap; all six merge-tree checks pass. ADV-0054 changes the push secret boundary and remains a separate, file-disjoint PR. ADV-0069 owns complete canonical Roborazzi coverage and must also remain separate.
Keep this PR in draft until first-time-fork approval, the exact hosted Ubuntu quality job, the preserved hosted macOS release-bundle job, privacy/log review, timeout observation, and required-check transition review pass. No merge, release, or deployment is authorized by local evidence.