Skip to content

ci(android): keep release secrets out of push checks - #1555

Draft
Jeremy1844 wants to merge 2 commits into
Adventech:mainfrom
Jeremy1844:fix/adv-2026-0054-no-secrets-in-push-ci
Draft

ci(android): keep release secrets out of push checks#1555
Jeremy1844 wants to merge 2 commits into
Adventech:mainfrom
Jeremy1844:fix/adv-2026-0054-no-secrets-in-push-ci

Conversation

@Jeremy1844

Copy link
Copy Markdown

Audit: ADV-2026-0054 / RC-0054

Root cause

The ordinary push workflow materializes release/store configuration with secrets.ENCRYPT_KEY before running public quality tasks. Those tasks complete without release material, so ordinary CI unnecessarily crosses the release-secret boundary.

Regression-first fix

  • Audited base: 55405f66a8c555047dc0035747acdcaa371d59fa
  • Failing regression commit: 2958523bd571e56530f0e8a7c04b8e9725d476a8
  • Fix/head: ef53825164d6ca887ac7fcad329b966f14595df8
  • Shape: two commits for one root; 2 files, +37/-5

The regression reports 2 pass / 1 fail on the base and 3/3 at the head. The fix removes only the five-line decrypt step from ordinary push CI; it does not read, rewrite, or publish encrypted material.

Recorded evidence

No application/content/schema/signing-material change, release, deployment, or protected-branch write is included.

Draft gates

A pull-request workflow cannot exercise .github/workflows/on_push.yml. Keep this draft until a maintainer runs the exact head on an authorized nonproduction upstream validation branch and confirms that hosted Ubuntu completes the quality commands without requesting or materializing release secrets. Canonical Linux screenshot review and the protected release boundary remain separate roots. Do not use main/develop release automation as a dry run because it can upload to internal Play tracks.

Migration/recovery: none; stored data and artifact formats are unchanged. Rollback should not restore decryption to ordinary CI—if a quality task needs configuration, use a synthetic non-secret fixture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant