Skip to content

fix: 3 bare excepts should catch ValueError instead of BaseException #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhhhcodes wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: 3 bare excepts should catch ValueError instead of BaseException #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/extract_rankings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def extract_rankings():
# Check if Rank is numeric, if not skip (it might be a comment row)
try:
rank = int(rank_val)
except:
except ValueError:
continue

item = {
Expand Down
4 changes: 2 additions & 2 deletions scripts/extract_rankings_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def safe_float(val):
if match:
try:
return float(match.group(1))
except:
except ValueError:
pass
return 0.0

Expand Down Expand Up @@ -96,7 +96,7 @@ def extract_rankings():

try:
rank = int(rank_val)
except:
except ValueError:
continue

if i == 0:
Expand Down
Loading