fix: 3 bare excepts should catch ValueError instead of BaseException - #813
Open
saurabhhhcodes wants to merge 1 commit into
Open
fix: 3 bare excepts should catch ValueError instead of BaseException#813saurabhhhcodes wants to merge 1 commit into
saurabhhhcodes wants to merge 1 commit into
Conversation
Contributor
Author
|
🔔 Friendly ping @Aditya948351 — this real fix has passing CI and references an approved GSSoC issue. Ready for review/merge. Thanks! |
1 similar comment
Contributor
Author
|
🔔 Friendly ping @Aditya948351 — this real fix has passing CI and references an approved GSSoC issue. Ready for review/merge. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real bugs: 3 bare 'except:' in extract_rankings.py and extract_rankings_v2.py catch BaseException (KeyboardInterrupt, SystemExit). Changed to except ValueError since only int()/float() conversion is expected.