Skip to content

fix(firms): reject blank/out-of-range CSV coords and UTC calendar rollover #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ATLURI0001 merged 1 commit into from
Nov 11, 2026
+38 −5
Merged

fix(firms): reject blank/out-of-range CSV coords and UTC calendar rollover #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions src/data/firmsCsv.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,21 @@ export function parseFirmsCsv(text) {
if (!line) continue;
const parts = line.split(',');
if (parts.length < header.length) continue; // malformed row — skip
const lat = Number(parts[iLat]);
const lon = Number(parts[iLon]);
if (!Number.isFinite(lat) || !Number.isFinite(lon)) continue;
const latText = parts[iLat]?.trim() ?? '';
const lonText = parts[iLon]?.trim() ?? '';
if (!latText || !lonText) continue;
const lat = Number(latText);
const lon = Number(lonText);
if (
!Number.isFinite(lat) ||
!Number.isFinite(lon) ||
lat < -90 ||
lat > 90 ||
lon < -180 ||
lon > 180
) {
continue;
}

records.push({
lat,
Expand Down Expand Up @@ -145,9 +157,19 @@ export function acquisitionMsUtc(acqDate, acqTime) {
day > 31 ||
hours > 23 ||
minutes > 59
)
) {
return NaN;
return Date.UTC(year, month - 1, day, hours, minutes);
}
const ms = Date.UTC(year, month - 1, day, hours, minutes);
const check = new Date(ms);
if (
check.getUTCFullYear() !== year ||
check.getUTCMonth() !== month - 1 ||
check.getUTCDate() !== day
) {
return NaN;
}
return ms;
}

/**
Expand Down
11 changes: 11 additions & 0 deletions src/data/firmsCsv.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,14 @@ test('acquisitionMsUtc: "0" = midnight UTC; garbage → NaN', () => {
);
assert.ok(Number.isNaN(acquisitionMsUtc('not-a-date', '1006')));
assert.ok(Number.isNaN(acquisitionMsUtc('2026-07-16', 'xx')));
// Calendar rollover dates (e.g. Feb 30, Apr 31, non-leap Feb 29) -> NaN
assert.ok(Number.isNaN(acquisitionMsUtc('2026-02-30', '1006')));
assert.ok(Number.isNaN(acquisitionMsUtc('2026-04-31', '1006')));
assert.ok(Number.isNaN(acquisitionMsUtc('2026-02-29', '1006')));
assert.equal(
acquisitionMsUtc('2024-02-29', '1006'),
Date.UTC(2024, 1, 29, 10, 6),
);
});

test('header-only input → []', () => {
Expand All @@ -90,6 +98,9 @@ test('malformed rows are skipped, valid rows kept', () => {
'not,enough,fields',
'garbage-line-with-no-commas',
'NaN,-121.67046,303.6,0.39,0.36,2026-07-16,1006,N20,VIIRS,n,2.0NRT,290.73,0.53,N',
',-121.67046,303.6,0.39,0.36,2026-07-16,1006,N20,VIIRS,n,2.0NRT,290.73,0.53,N',
'95.0,-121.67046,303.6,0.39,0.36,2026-07-16,1006,N20,VIIRS,n,2.0NRT,290.73,0.53,N',
'38.99488,-181.5,303.6,0.39,0.36,2026-07-16,1006,N20,VIIRS,n,2.0NRT,290.73,0.53,N',
'38.99488,-121.67046,303.6,0.39,0.36,2026-07-16,1006,N20,VIIRS,n,2.0NRT,290.73,0.53,N',
].join('\n');
const records = parseFirmsCsv(text);
Expand Down
Loading