Skip to content

fix(firms): reject blank/out-of-range CSV coords and UTC calendar rollover - #2

Merged
ATLURI0001 merged 1 commit into
mainfrom
fix/firms-csv-coord-and-calendar-validation
Nov 11, 2026
Merged

ATLURI0001 merged 1 commit into
mainfrom
fix/firms-csv-coord-and-calendar-validation

Conversation

@ATLURI0001

Copy link
Copy Markdown
Owner

Summary of Changes

  • FIRMS CSV Coordinate & Calendar Validation (src/data/firmsCsv.js):
    • Guarded parseFirmsCsv() against blank latitude/longitude cells (which previously coerced Number("") to 0, injecting phantom fire detections at (0, 0)) and enforced WGS84 range bounds (lat in [-90, 90], lon in [-180, 180]).
    • Added strict UTC calendar round-trip verification in acquisitionMsUtc() so impossible dates such as 2026-02-30, 2026-04-31, or 2026-02-29 return NaN rather than silently rolling over to the following month via Date.UTC.
  • Automated Test Coverage (src/data/firmsCsv.test.mjs):
    • Expanded unit tests covering blank coordinate rejection, out-of-range latitude/longitude filtering, and leap/non-leap calendar date rollover validation.

@ATLURI0001
ATLURI0001 merged commit fa39eb7 into main Nov 11, 2026
1 of 3 checks passed
@ATLURI0001
ATLURI0001 deleted the fix/firms-csv-coord-and-calendar-validation branch November 11, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant