Repository navigation
feat(http): migrate REPL .http + plugin onto http_query_server - #16
Merged
Merged
Conversation
Both run a background HTTP server (no main-thread queue), so use use_queue=false + serialize_requests=true (libxsql v1.0.10) to preserve per-request serialization (BN QueryEngine / per-request engine over a shared BinaryView is not concurrency-safe). statement_executor replaces the setup_http_routes path; /settings preserved via extra_routes. With the CLI already migrated, all three bnsql HTTP entry points now use the shared thinclient; setup_http_routes is unused (left for a follow-up cleanup). REPL .http tested live (query, continue_on_error, format=csv, /settings). Plugin uses the identical thinclient path (BinaryView executor); compile-verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes bnsql's HTTP convergence: the REPL
.httpcommand and the Binary Ninja plugin now usexsql::thinclient::http_query_server(statement_executor), like the CLI (#15).Both are background servers (no main-thread queue), so they use
use_queue=false+serialize_requests=true(libxsql v1.0.10) to keep per-request serialization — BN'sQueryEngine(and a per-request engine over the shared BinaryView) isn't concurrency-safe./settingspreserved viaextra_routes.All three bnsql HTTP entry points now share the thinclient;
setup_http_routesis unused (left for a follow-up cleanup; helpershttp_help_text/settings_to_jsonstill used).Tested
.httplive: query,?continue_on_error=1,?format=csv,/settings✓