Repository navigation
chore(http): remove dead setup_http_routes - #17
Merged
Merged
Conversation
All three bnsql HTTP entry points (CLI/REPL/plugin) now use xsql::thinclient::http_query_server, so the hand-rolled setup_http_routes (and the HttpQueryFn typedef) are unused. Remove them; keep http_help_text() and settings_to_json(), still used to configure the thinclient. No behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #15/#16. With all three bnsql HTTP entry points (CLI
--http, REPL.http, plugin) now onxsql::thinclient::http_query_server, the hand-rolledsetup_http_routes+HttpQueryFntypedef are unused. Removed (~194 lines);http_help_text()/settings_to_json()kept (still configure the thinclient). Builds clean (CLI + plugin); no behavior change.