Skip to content

Change PollingInterval #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0suu merged 1 commit into from
Nov 23, 2025
Merged

Change PollingInterval #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ interface AppSettings {
const schema = {
apiToken: { type: "string" },
apiSecret: { type: "string" }, // For storing the secret, consider encryption
pollingIntervalSeconds: { type: "number", default: 10 },
pollingIntervalSeconds: { type: "number", default: 60 },

@gemini-code-assist gemini-code-assist Bot Nov 23, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Changing the default polling interval to 60 seconds is a great improvement for preventing API rate limit issues.

To make this even more robust, I suggest adding a minimum value to the schema, as shown in the suggestion. The SwitchBot API is limited to 10,000 requests/day (~1 every 8.6s), so a very low polling interval can cause problems. By setting a minimum, you can prevent users from choosing a value that is too aggressive. A minimum of 10 seconds would be a safe floor.

Important Note: Adding this validation will cause electron-store to throw an error if an attempt is made to set a value below the minimum. You'll need to ensure that the UI and state management logic can handle this validation gracefully (e.g., by updating the input validation in SettingsScreen.tsx and handling the electron-store set call in a try...catch block or a thunk).

Suggested change
pollingIntervalSeconds: { type: "number", default: 60 },
pollingIntervalSeconds: { type: "number", default: 60, minimum: 10 },

theme: { type: "string", default: "dark" },
logRetentionDays: { type: "number", default: 7 },
};
Expand Down