Skip to content

Change PollingInterval#6

Merged
0suu merged 1 commit into
mainfrom
suu/ChangeDefaultPollingInterval
Nov 23, 2025
Merged

Change PollingInterval#6
0suu merged 1 commit into
mainfrom
suu/ChangeDefaultPollingInterval

Conversation

@0suu

@0suu 0suu commented Nov 23, 2025

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @0suu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts the default polling frequency within the application's settings. The primary purpose of this change is to reduce the frequency of background operations, which can lead to lower resource consumption and fewer API calls for users who rely on the default configuration.

Highlights

  • Default Polling Interval: The default value for the pollingIntervalSeconds setting has been increased from 10 seconds to 60 seconds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the default polling interval from 10 to 60 seconds. This is a sensible change that will help prevent users from hitting the SwitchBot API rate limits. I've added a suggestion to also enforce a minimum polling interval in the configuration schema to make the setting more robust and prevent users from setting a dangerously low value.

Comment thread src/main/main.ts
apiToken: { type: "string" },
apiSecret: { type: "string" }, // For storing the secret, consider encryption
pollingIntervalSeconds: { type: "number", default: 10 },
pollingIntervalSeconds: { type: "number", default: 60 },

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Changing the default polling interval to 60 seconds is a great improvement for preventing API rate limit issues.

To make this even more robust, I suggest adding a minimum value to the schema, as shown in the suggestion. The SwitchBot API is limited to 10,000 requests/day (~1 every 8.6s), so a very low polling interval can cause problems. By setting a minimum, you can prevent users from choosing a value that is too aggressive. A minimum of 10 seconds would be a safe floor.

Important Note: Adding this validation will cause electron-store to throw an error if an attempt is made to set a value below the minimum. You'll need to ensure that the UI and state management logic can handle this validation gracefully (e.g., by updating the input validation in SettingsScreen.tsx and handling the electron-store set call in a try...catch block or a thunk).

Suggested change
pollingIntervalSeconds: { type: "number", default: 60 },
pollingIntervalSeconds: { type: "number", default: 60, minimum: 10 },

@0suu
0suu merged commit 0d12fcd into main Nov 23, 2025
2 checks passed
@0suu
0suu deleted the suu/ChangeDefaultPollingInterval branch November 23, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant