Fix 500 error on decklists/by_date for days with no decklists#363
Open
jwstover wants to merge 1 commit into
Open
Fix 500 error on decklists/by_date for days with no decklists#363jwstover wants to merge 1 commit into
jwstover wants to merge 1 commit into
Conversation
listDecklistsByDateAction computed max() over the decklists' update dates to set the Last-Modified header, but max() fails on an empty array, so any date with zero published decklists returned HTTP 500 instead of an empty result. Skip the Last-Modified handling when the day is empty and return an empty JSON array with status 200. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
listDecklistsByDateAction computed max() over the decklists' update dates to set the Last-Modified header, but max() fails on an empty array, so any date with zero published decklists returned HTTP 500 instead of an empty result. Skip the Last-Modified handling when the day is empty and return an empty JSON array with status 200.