Repository navigation
chore: standardise on node 24 - #101
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@types/nodefrom^20.19.25to^24engines.node: "24.x"to package.json.node-versionpinning24.18.0.github/workflows/test.ymlcontainer image and node-version from 22 to 24Test plan
pnpm installpnpm run build(succeeds; internal next lint step surfaces a pre-existing, unrelated eslint-config-next resolution error)pnpm vitest run(55 tests passed)Note:
pnpm run lintcurrently fails withCannot find module '.../eslint-config-next/core-web-vitals'— this is a pre-existing issue caused byeslint-config-nextbeing pinned to15.1.6(noexportsmap, doesn't resolve the extensionless subpath import used ineslint.config.mjs) while@next/eslint-plugin-nextis on^15.5.6. It is unrelated to the Node version bump and reproduces regardless of Node version; left untouched as out of scope for this change.