action: add option to disable apt-cacher - #14
Merged
Conversation
Add an option to disable (stop actually) apt-cacher-ng before running the test. Make sure the socket is cleaned up so that image-garden would not pick it up and try to setup proxing. Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
zyga
reviewed
Jan 23, 2026
zyga
left a comment
zyga
left a comment
Owner
There was a problem hiding this comment.
Looks good. It'd be nice to update README.md as well.
There was a problem hiding this comment.
Pull request overview
This pull request adds a new input option cache-deb-packages to control whether apt-cacher-ng should be used for caching Debian packages during image preparation. When disabled, the action stops the apt-cacher-ng service and removes its socket file to prevent image-garden from attempting to use it for proxying.
Changes:
- Added new boolean input
cache-deb-packageswith default value oftrueto maintain backward compatibility - Added a new step to disable apt-cacher-ng service when caching is disabled
- Implemented socket cleanup to ensure image-garden doesn't try to use a disabled service
Signed-off-by: Maciek Borzecki <maciek.borzecki@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an option to disable (stop actually) apt-cacher-ng before running the test. Make sure the socket is cleaned up so that image-garden would not pick it up and try to setup proxing.