This repository was archived by the owner on Jul 21, 2026. It is now read-only.
Fix renumbering bugs - #194
Open
bduffany wants to merge 1 commit into
Open
Conversation
bduffany
force-pushed
the
renumbering-fix
branch
from
March 22, 2026 19:35
32f730c to
e6d140a
Compare
bduffany
marked this pull request as ready for review
March 22, 2026 19:36
bduffany
force-pushed
the
renumbering-fix
branch
5 times, most recently
from
March 22, 2026 19:53
efbbb0c to
0540f2d
Compare
Fix three renumbering bugs in proto3RenumberLogic: - avoid rewriting field or enum names that contain digits when renumbering values - replace full hexadecimal enum literals instead of corrupting partial matches - ignore braces inside comments and strings when locating renumbering blocks Add focused regression tests for each case. Signed-off-by: Brandon Duffany <brandon@buildbuddy.io>
bduffany
force-pushed
the
renumbering-fix
branch
from
March 22, 2026 22:27
0540f2d to
c4b905a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three renumbering bugs:
Add regression tests for each case, which demonstrate the bugs being fixed.
Also, introduces a test helper
applyEditsto make some of the tests clearer (it allows asserting on the actual before/after of the replacement, making the assertion more obvious)Fixes #190