This repository was archived by the owner on Jul 21, 2026. It is now read-only.
Add protoSrcsDir config option - #150
Open
codersasha wants to merge 6 commits into
Open
Conversation
|
Something like this is badly needed for our monorepo. Without it "go to definition" is extremely slow, taking 10-30 seconds. Even when the definition is in the same file. 😅 |
Greateapot
added a commit
to Greateapot/vscode-proto3
that referenced
this pull request
Jul 17, 2024
Collaborator
|
@codersasha please update the PR and I'll merge it :) Great addition! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new config option,
protoSrcsDir, which optionally limits the scope of proto file searches from{workspaceRoot}/**down to{workspaceRoot}/path/to/protos/**. This fixes an issue where autocompletion and go-to-definition calls are unuseably slow (upwards of 30 seconds) in repos with large numbers of ignored files (e.g.node_modules,bazel-out). With this fix, they are instant.The "proper" way to fix this would be to respect VSCode's existing ignore lists in
settings.json, but I'm not sure how to do that with fastglob in a way that actually improves performance. So, this solves the issue for now :)