refactor(backend): land backend refactor stack#4747
Draft
robertsLando wants to merge 6 commits into
Draft
Conversation
Adds HTTP contract coverage before the backend is decomposed. - Locks the 35 routes’ authentication, response shapes, status/header/stream behavior, and side effects. - Keeps production routing unchanged behind a minimal app-construction seam. - Review focus: contract fidelity and assertions that target application behavior rather than harness mechanics. Part of #4722. Stack root on `backend-refactor`. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: robertsLando <daniel.sorridi@gmail.com>
27 tasks
Coverage Report for CI Build 29563628241Coverage increased (+30.1%) to 38.102%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Member
Author
|
cc @AlCalzone here we can keep track of the issues closed by this otherwise marging prs into this branch want close the issues |
Locks the current Socket.IO and dynamic Z-Wave API wire behavior before backend handlers and classes are split. - Review the real HTTP/Socket.IO harness isolation and test-only `createApp()` hooks. - Verify the seven inbound and 24 outbound event contracts, ACK envelopes, authentication fallback, room routing, producer payloads, and timing. - Confirm the complete `allowedApis`/`callApi()` compatibility surface, including underscore-prefixed APIs and preserved wire quirks, without consumer changes. Stacked on #4723. Part of #4722. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Locks both Home Assistant integrations before they are moved. - Covers legacy MQTT discovery, custom-device loading, persistence, and `@zwave-js/server` lifecycle behavior. - Preserves existing topic, payload, cache, and startup-order quirks. - Review focus: whether fixtures describe production contracts rather than fake or helper behavior. Part of #4722. Stacked on #4724. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft. Landing PR for the backend refactor stack (umbrella: #4722). This aggregates the linear stack staged on the
backend-refactorintegration branch and is the surface where the cumulative diff gets reviewed as one unit and where issue-closure actually fires.Do not merge until the full stack (#4723 → #4742) has landed on
backend-refactorand this PR reflects the complete change. Review order, tiering and the merge train are tracked in #4745.Why this PR exists
The stack merges PR-by-PR into
backend-refactor, not intomaster. Closing keywords on those sub-PRs are inert (they target a non-default branch, so GitHub never creates the links) and do not replay when this branch lands. This PR — which does target the default branch — is the only place aCloseskeyword works.Issue closure
Closes #4722— the umbrella backend-refactor requirement.circuit_4state-topic bug (fix(hass): correct PE653 circuit 4 discovery state topic #4738), password hashes in session files (fix(auth): keep password hashes out of session files #4739), socket ack asymmetries (fix(socket): normalize inbound API failures and acknowledgements #4740). They are the follow-up backlog this refactor produces. fix(socket): normalize inbound API failures and acknowledgements #4740 was partially addressed — re-scope by hand.Before marking ready for review
backend-refactorbackend-refactorsynced with latestmasterCloses #4722