ci: test across Node 22 and 24 in ci.yml#1572
Merged
Merged
Conversation
Uses a matrix instead of a single pinned version so the workflow actually tests across multiple Node versions, matching what the workflow's own comment claims.
raman325
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.ymlclaimed to test "across different versions of node" but only ran a single pinned Node 24 job. Expanded it to a[22, 24]matrix so it matches that claim and drops Node 20 (EOL April 2026) from consideration.npmpublish.ymlwas reviewed but left untouched — it already usesactions/checkout@v7,actions/setup-node@v6, Node 24, OIDC trusted publishing, and dist-tag detection viaactions/github-script, so there was nothing outdated to change. Itsrelease: publishedtrigger (drafted by release-drafter, then manually published) is intentionally kept as-is.release-drafter.ymlwas left untouched per instructions.This aligns
ci.ymlwith the Node-version matrix pattern already rolled out in AlCalzone/jsonl-db, zwave-js/waddle and AlCalzone/node-coap-client.