Complete Phase 1.5 evidence gates - #1
Closed
angerman wants to merge 20 commits into
Closed
Conversation
Record hosted Sixel and iTerm2 image evidence as accepted while keeping Windows ConPTY as the remaining live smoke gate. Wire the evidence invariant into make check.
Run the ConPTY sentinel proof before exit, try LF before a fresh CRLF fallback, fail short writes, and add portable smoke-helper coverage plus RCA handoff notes for the remaining Windows evidence gate.
Record the exact ConPTY RCA implementation commit in the dated handoff so the remaining Windows evidence gate can be resumed from a concrete revision.
Emit a machine-readable hosted Windows ConPTY acceptance manifest and sidecar command/meta artifacts so the remaining Phase 1.5 smoke gate has a concrete predicate.
Record the exact hosted ConPTY evidence manifest commit in the Phase 1.5 handoff.
Add a strict local verifier for downloaded hosted Windows ConPTY artifacts, with synthetic positive and negative fixtures wired into make check.
Record the exact hosted ConPTY evidence verifier commit in the handoff.
Tighten hosted ConPTY artifact verification so compile-only commands or non-Windows metadata cannot satisfy the remaining Phase 1.5 evidence gate.
Match the documented ConPTY setup lifetime by keeping the pseudoconsole pipe ends alive until after CreateProcessW, and guard the ordering with a source regression check.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR carries the local Phase 1.5 work currently staged on local master without pushing directly to master.\n\nHighlights:\n- Windows ConPTY smoke harness hardening and hosted evidence manifest generation.\n- Hosted ConPTY artifact verifier wired into make check.\n- Phase 1.5 evidence docs aligned around the remaining Windows ConPTY predicate.\n\nEvidence command after Hosted visual probes completes:\n\n
sh\nnix develop -c make verify-conpty-evidence ARTIFACT_DIR=artifacts/gh-runs/<run>/hosted-visual-windows-terminal COMMIT=3fc9be2db2aa528446da2cf2acec6b748f764267\n\n