Add oxocarbon dark and light themes - #1647
Open
artisanbk wants to merge 1 commit into
Open
Conversation
Adds the oxocarbon dark and light themes, with their shared palette factored into colors_oxocarbon.py, following the structure of the existing gruvbox theme files. Registers both in config/themes.py. The dark theme renders the carbon accents on a near-black background; the light theme uses a white background with a slate foreground and deeper blue/purple accents for contrast. Syntax highlighting uses the Material (dark) and Lovelace (light) pygments styles as bases, with token overrides nudged towards the oxocarbon accents. The palette is adapted from oxocarbon.nvim (MIT License), Copyright (c) 2022 Riccardo Mazzarini; the full notice is in colors_oxocarbon.py. https://github.com/nyoom-engineering/oxocarbon.nvim Tests updated to expect both themes as complete bundled themes. Documentation updated in docs/FAQ.md to list both themes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
Adds two new bundled themes —
oxocarbon_darkandoxocarbon_light—derived from the oxocarbon
(IBM Carbon) palette, giving users another dark/light theme pair.
Their shared palette is factored into
colors_oxocarbon.py, following thestructure of the existing gruvbox theme files, and both are registered in
config/themes.py.oxocarbon_darkrenders the carbon accents on a near-black background.oxocarbon_lightuses a white background with a slate foreground anddeeper blue/purple accents for contrast.
Syntax highlighting uses the Material (dark) and Lovelace (light) pygments
styles as bases, with token overrides nudged towards the oxocarbon accents.
The palette is adapted from oxocarbon.nvim (MIT License), Copyright (c) 2022
Riccardo Mazzarini; the full notice is included in
colors_oxocarbon.py.Outstanding aspect(s)
contrast choices are somewhat subjective — happy to adjust to reviewer
preference.
External discussion & connections
topicHow did you test this?
Self-review checklist for each commit
Visual changes
oxocarbon_dark
oxocarbon_light