Feat/autocomplete users - #1643
Draft
mubarak-mustopha wants to merge 4 commits into
Draft
Conversation
This retrieves the sender ids of the messages in that topic excluding id of the current user.
This sorts private_msg_ids by timestamp and retrives the display_recipient_ids of the associated Message objects.
mubarak-mustopha
force-pushed
the
feat/autocomplete_users
branch
2 times, most recently
from
May 10, 2026 14:57
a8ba347 to
88b211c
Compare
Fixes zulip#1526. Prioritize users with recent DMs after users in current topic then stream.
mubarak-mustopha
force-pushed
the
feat/autocomplete_users
branch
from
May 10, 2026 14:59
88b211c to
785d04b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why?
This PR fixes #1526.
What I added
get_user_ids_in_topic_narrowtoModelWhat's already included
WriteBox._setup_common_stream_compose()sets the value ofWriteBox.recipient_user_idsto the users in the current streamModel._update_users_data_from_initial_data()orders user data by status which prioritizes humans over bots.External discussion & connections
topicHow did you test this?
Self-review checklist for each commit
Visual changes
Before
autocomplete_unfixed.webm
After
autocomplete_partial_fix.webm