message-rendering: Rendering horizontal rule in messagebox. - #1621
Open
omseervi098 wants to merge 2 commits into
Open
message-rendering: Rendering horizontal rule in messagebox.#1621omseervi098 wants to merge 2 commits into
omseervi098 wants to merge 2 commits into
Conversation
zulipbot
added
size: M
omseervi098
force-pushed
the
add-horizontal-rule
branch
from
February 23, 2026 02:27
960a51f to
ad01c25
Compare
Updated PopUpView and StreamInfoView to work with this change. Added a horizontal rule example in MarkDownHelpView and tests.
zulipbot
added
size: XL
neiljp
reviewed
Mar 2, 2026
neiljp
left a comment
neiljp
left a comment
Collaborator
There was a problem hiding this comment.
@omseervi098 Please keep changes related to the description of a commit in that commit, and other changes elsewhere, ie. in commits before or after.
Relevant changes are good to include in a PR, but it is difficult to review individual commits when they are large or have unrelated lines.
Comment on lines
30
to
+36
| QUOTED_TEXT_MARKER = "░" # LIGHT SHADE, U+2591 (Block elements) | ||
|
|
||
| # Extends from end of recipient details (above messages where recipients differ above) | ||
| MESSAGE_HEADER_DIVIDER = "━" # BOX DRAWINGS HEAVY HORIZONTAL, U+2501 (Box drawing) | ||
|
|
||
| # Message body horizontal rule (<hr>) | ||
| MESSAGE_RULE_LINE = "─" # BOX DRAWINGS LIGHT HORIZONTAL, U+2500 (Box drawing) |
Collaborator
There was a problem hiding this comment.
Thanks for adding the distinct new symbol name 👍
Only very minor note here is to keep similar things together, and MESSAGE_RULE_LINE is in a message, so probably best next to QUOTED_TEXT_MARKER :)
neiljp
reviewed
Mar 2, 2026
Comment on lines
+122
to
+126
| { # HORIZONTAL RULE | ||
| "name": "Horizontal Rule", | ||
| "raw_text": "---", | ||
| "html_element": "<hr>", | ||
| }, |
Collaborator
There was a problem hiding this comment.
This is good to include, for the help in the app 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1620
What does this PR do, and why?
Add Horizontal Rule rendering support for message box
External discussion & connections
topicHow did you test this?
Self-review checklist for each commit
Visual changes