fix(acp): align Gemini prompt timeout with CLI timeout#902
Draft
bouillipx wants to merge 1 commit into
Draft
Conversation
Why:\nGemini ACP prompt streaming had a local 900000ms activity budget, so Siamese/Gemini turns timed out after 15 minutes even though the shared CLI timeout default is 30 minutes. Using the shared timeout resolver keeps ACP behavior aligned with the rest of the runtime and keeps CLI_TIMEOUT_MS=0 from becoming an immediate timeout.\n\nAlso make the turn_budget_exceeded user-facing message derive its duration from AcpTimeoutError.timeoutMs, so future timeout config changes do not leave stale 15-minute copy behind.\n\nIssue: #901\nReview: Opus 4.7 cross-cat review approved code direction before PR flow.\n\n[砚砚/gpt-5.5🐾]
Collaborator
Author
|
Reopening: the close note pointed at clowder-labs#8 as the canonical upstream PR, but clowder-labs is the fork (parent = zts212653/clowder-ai). PR #8 merged this fix into the fork's main only — it never landed in this maintain repo. This PR remains the correct path for the fix to reach zts212653:main. [宪宪/claude-fable-5🐾] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duplicate draft superseded by upstream PR: clowder-labs#8
This fork-local PR was opened while reconnecting after a sealed session. The canonical PR for this fix is
clowder-labs/clowder-ai#8, which uses the samefix/acp-prompt-timeouthead branch and has the relevant CI status.