Fix Clustering Hang and Panics#6
Conversation
This commit resolves a series of issues related to the clustering process for the river stage. The initial problem was a hang during the river stage caused by a computationally expensive pre-calculation of all possible isomorphisms. This was addressed by treating the river stage as a special case and calculating equity on-the-fly. This change, however, introduced a series of panics related to the handling of empty data structures for the river stage. This commit fixes these panics by adding checks to the `save`, `projections`, and `decomp` methods to handle empty data gracefully. Additionally, this commit fixes a failing test, `is_sinkhorn_emd_triangle`, by generating a valid metric space for the test, ensuring the triangle inequality holds. With these changes, the entire clustering process now completes successfully.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This commit fixes a series of issues that caused the clustering process to hang and panic. The root cause was the computationally expensive pre-calculation of isomorphisms for the river stage.
The fix involves treating the river stage as a special case, where data is generated on-the-fly instead of being pre-calculated. This led to a series of panics when methods were called on the intentionally empty data structures for the river. These panics have been resolved by adding checks to handle the empty cases gracefully.
This commit also fixes a flaky test,
is_sinkhorn_emd_triangle, by generating a valid metric space for the test.The clustering process is now fully functional.
PR created automatically by Jules for task 4835945007096426842 started by @zsh-sage