Repository navigation
sync-skill: label protocol-bump syncs at creation, retarget an open PR in place - #130
Merged
Merged
Conversation
… an open PR in place PR #129's first CI run failed cross-version wire compatibility on the runtime-launcher protocol ratchet: v1.4.232 bumped the daemon protocol (49->50) and touched launcher files in separate upstream PRs, which a sync diff carries as one. The allow-runtime-launcher-protocol-bump label is the sanctioned path (#115, #122 used it), but pr.yml has no labeled trigger, so adding it late cost a CI round. Step 9 now says to pass the label to gh pr create when daemon-protocol-version.ts moved. The same PR then failed session-scanner-scope-cwd-facts. Running the test at the bare tag with test:sandbox --source-ref=v1.4.232 reproduced it, proving an upstream defect, and v1.4.233 (stablyai#31098) fixed it. The fix policy said to retarget but not how with a PR open and no permission to create a branch; it now does.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
Two things the v1.4.232/v1.4.233 sync run (PR #129) learned the hard way, written into the sync skill so the next run doesn't repeat them.
What Changed
--label allow-runtime-launcher-protocol-bumptogh pr create. PR sync: absorb upstream v1.4.233 #129's first run failedcross-version wire compatibilitywithFAIL: split the protocol bump and the runtime launcher change into separate PRs, atdaemon PROTOCOL_VERSION: base 49, candidate 50and four launcher files. Upstream made those changes in separate PRs; the sync diff carries them as one. sync: absorb upstream v1.4.224 #115 and sync: absorb upstream v1.4.230 #122 needed the same label.pr.ymlhas nolabeledtrigger, so labeling after the first run only counts from the next push, which cost a CI round here.pnpm test:sandbox --shards=1 --source-ref=<tag> -- <test>reproducedsession-scanner-scope-cwd-factsat barev1.4.232) and how to retarget with the PR already open: merge the newer tag into the same branch by Steps 5–8, push, retitle. The skill can't create a branch, so a second PR isn't an option. v1.4.233 (test(ai-vault): stop the cold-authority scope test depending on the clock stablyai/orca#31098) fixed the test, and sync: absorb upstream v1.4.233 #129 merged both tags as9bd674f464.Why
Both edits sit in the step that owns the decision rather than in
sync-lessons.md, because each is a rule the next run has to act on. Neither touches the hard safety rules or the fix policy's never-list.Linked Issue
N/A. Sync-skill lesson from PR #129.
Visual Proof
N/A. Documentation only.
Testing
config/scripts/sync-upstream-file-ownership.test.mjsreads this skill. The only script it names ischeck-runtime-launcher-protocol-ratchet.mjs, which exists, and PR CI runs the test.