feat(mesh): add HSL color interpolation space - #26
Open
MrNihalT wants to merge 1 commit into
Open
Conversation
|
@MrNihalT is attempting to deploy a commit to the zoxilsi's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hey! This PR adds support for HSL (Hue, Saturation, Lightness) color space blending to the gradient editor.
Why
Currently, if you try to blend opposite colors (like blue and yellow) in RGB or Linear space, the math cuts straight through the color cube and creates a dull, muddy grey or brown area in the middle of the transition.
Related issue
Closes #
Type of change
feat)fix)perf)How was this tested?
pnpm checklocally—TypeScript compiles, lint checks pass, and the production static build generated successfully without issues.pnpm dev) and manually checked it in Chrome. Selecting HSL blending renders smoothly and looks incredibly vibrant!Checklist
pnpm checkpasses locallyScreenshots / recordings
Notes for reviewers
lib/color.tsand the GLSL math is inshaders/meshPass.ts. Feel free to review the conversion steps!